New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local gulp in CI #35474

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@felixfbecker
Contributor

felixfbecker commented Oct 2, 2017

We already install gulp in node_modules, installing it again globally takes ~17s on every build.
It also means that we currently always use the latest version of Gulp (if Gulp 4 came out tomorrow, CI would break). This always uses the same version in package.json / npm-shrinkwrap.json.

All the shell scripts already reference gulp and mocha from node_modules, so no changes needed there.

@bpasero bpasero assigned joaomoreno and unassigned bpasero Oct 2, 2017

@joaomoreno joaomoreno merged commit 38ae918 into Microsoft:master Oct 3, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Oct 3, 2017

Member

Awesome stuff, thanks @felixfbecker! 🍻

Member

joaomoreno commented Oct 3, 2017

Awesome stuff, thanks @felixfbecker! 🍻

@joaomoreno joaomoreno added this to the October 2017 milestone Oct 3, 2017

@felixfbecker felixfbecker deleted the felixfbecker:use-local-gulp branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment