New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kludge that adds history item when new input is set on an editor #35682

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
2 participants
@beyang
Contributor

beyang commented Oct 6, 2017

This is not related to any issue, but I noticed this code that seemed kludge-y and perhaps no longer necessary. The code was originally added to fix #11727, but when I remove it, the behavior remains correct. The history item this adds appears now to be redundant, and could cause issues down the line, even though it doesn't appear to cause any user-visible issues now. This is also the only place that HistoryService.add is invoked outside of HistoryService itself.

@bpasero bpasero self-assigned this Oct 6, 2017

@bpasero bpasero added this to the October 2017 milestone Oct 6, 2017

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Oct 10, 2017

Member

Yeah looks like it because now we merge history locations more aggressively, I also think it can be removed. Thanks for noticing.

Member

bpasero commented Oct 10, 2017

Yeah looks like it because now we merge history locations more aggressively, I also think it can be removed. Thanks for noticing.

@bpasero bpasero merged commit 5a8042d into Microsoft:master Oct 10, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment