New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the "reason" arg for trimming trailing whitespace #35778

Merged
merged 3 commits into from Oct 24, 2017

Conversation

Projects
None yet
4 participants
@dgileadi
Contributor

dgileadi commented Oct 7, 2017

This is in support of #24400. The reason this enhancement is needed is that extensions like editorconfig-vscode call the editor.action.trimTrailingWhitespace command during an auto-save event, and without knowing whether the command was triggered by an auto-save event the code can't know whether to trim trailing whitespace at the cursor (causing the cursor to move) or not.

This change will allow fixing editorconfig-vscode #47.

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Oct 7, 2017

CLA assistant check
All CLA requirements met.

msftclas commented Oct 7, 2017

CLA assistant check
All CLA requirements met.

@jedmao

jedmao approved these changes Oct 8, 2017

@dgileadi

This comment has been minimized.

Show comment
Hide comment
@dgileadi

dgileadi Oct 18, 2017

Contributor

Hi @alexandrudima! Is there any thing I can do to help get this in?

Contributor

dgileadi commented Oct 18, 2017

Hi @alexandrudima! Is there any thing I can do to help get this in?

@alexandrudima

This comment has been minimized.

Show comment
Hide comment
@alexandrudima

alexandrudima Oct 24, 2017

Member

@dgileadi Sorry I'm a bit slow... I was "offline" for a bit to work on #36410

Member

alexandrudima commented Oct 24, 2017

@dgileadi Sorry I'm a bit slow... I was "offline" for a bit to work on #36410

@alexandrudima alexandrudima added this to the October 2017 milestone Oct 24, 2017

@alexandrudima

This comment has been minimized.

Show comment
Hide comment
@alexandrudima

alexandrudima Oct 24, 2017

Member

Thank you @dgileadi for your contribution ! ❤️
Thank you @jedmao for reviewing ❤️

Member

alexandrudima commented Oct 24, 2017

Thank you @dgileadi for your contribution ! ❤️
Thank you @jedmao for reviewing ❤️

@alexandrudima alexandrudima merged commit dd5e66e into Microsoft:master Oct 24, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.
Details

@dgileadi dgileadi deleted the dgileadi:trim-whitespace-preserve-cursor branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment