New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the EBNF for snippets #36067

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
2 participants
@maokelong
Contributor

maokelong commented Oct 11, 2017

I reviewed the parse's code and think that ${sn:-else} and ${sn:else} may have the same function and should share the same status,which means that the pattern should be something like '${' int ':-' else '}' | '${' int ':' else '}' or not '${' int ':-' else '}' '${' int ':' else '}'.

Correct the EBNF for snippets
I reviewed the parse's code and think that `${sn:-else}` and `${sn:else}` may have the same function and should share the same status,which means that  the pattern should be something like `'${' int ':-' else '}' | '${' int ':' else '}'` or not  '${' int ':-' else '}'  '${' int ':' else '}'.
@jrieken

This comment has been minimized.

Show comment
Hide comment
@jrieken

jrieken Oct 11, 2017

Member

Thanks

Member

jrieken commented Oct 11, 2017

Thanks

@jrieken jrieken merged commit cb4b274 into Microsoft:master Oct 11, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@jrieken jrieken added this to the October 2017 milestone Oct 11, 2017

@jrieken jrieken added the snippets label Oct 11, 2017

@jrieken

This comment has been minimized.

Show comment
Hide comment
@jrieken

jrieken Oct 11, 2017

Member

@gregvanl Can you also please the doc-page with this change. Thanks

Member

jrieken commented Oct 11, 2017

@gregvanl Can you also please the doc-page with this change. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment