New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency of Emmet messages #36251

Merged
merged 2 commits into from Oct 15, 2017

Conversation

Projects
None yet
3 participants
@qcz
Contributor

qcz commented Oct 13, 2017

Improve consistency of Emmet messages
- Start Emmet with capital E
- Write BEM with all caps like in the official documentation
@lipis

lipis approved these changes Oct 13, 2017

@ramya-rao-a

This comment has been minimized.

Show comment
Hide comment
@ramya-rao-a

ramya-rao-a Oct 15, 2017

Member

Thanks @qcz

Member

ramya-rao-a commented Oct 15, 2017

Thanks @qcz

@ramya-rao-a ramya-rao-a merged commit de68b07 into Microsoft:master Oct 15, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.
Details

sandy081 added a commit that referenced this pull request Oct 16, 2017

Improve consistency of Emmet messages (#36251)
- Start Emmet with capital E
- Write BEM with all caps like in the official documentation
@qcz

This comment has been minimized.

Show comment
Hide comment
@qcz

qcz Nov 6, 2017

Contributor

@ramya-rao-a: This PR is missing from the Thank You section of v1_18.md :)

Contributor

qcz commented Nov 6, 2017

@ramya-rao-a: This PR is missing from the Thank You section of v1_18.md :)

@qcz qcz deleted the qcz:patch-3 branch Nov 6, 2017

@ramya-rao-a ramya-rao-a added this to the October 2017 milestone Nov 6, 2017

@ramya-rao-a

This comment has been minimized.

Show comment
Hide comment
@ramya-rao-a
Member

ramya-rao-a commented Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment