New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing awaits #36265

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@nicksnyder
Contributor

nicksnyder commented Oct 14, 2017

This prevents the returned promises from prematurely resolving before the command finishes.

@joaomoreno joaomoreno merged commit 7e78566 into Microsoft:master Oct 16, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Oct 16, 2017

Member

Great catches. Thanks! 🍻

Member

joaomoreno commented Oct 16, 2017

Great catches. Thanks! 🍻

@joaomoreno joaomoreno added this to the October 2017 milestone Oct 16, 2017

@joaomoreno joaomoreno added the git label Oct 16, 2017

@nicksnyder nicksnyder deleted the nicksnyder:scmawait branch Oct 16, 2017

@felixfbecker

This comment has been minimized.

Show comment
Hide comment
@felixfbecker

felixfbecker Nov 9, 2017

Contributor

There is a TSLint rule that can catch this: https://palantir.github.io/tslint/rules/no-floating-promises/
It does not trigger if the Promise is returned, awaited or has an error handler.

Contributor

felixfbecker commented Nov 9, 2017

There is a TSLint rule that can catch this: https://palantir.github.io/tslint/rules/no-floating-promises/
It does not trigger if the Promise is returned, awaited or has an error handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment