Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing awaits #36265

Merged
merged 1 commit into from Oct 16, 2017
Merged

add missing awaits #36265

merged 1 commit into from Oct 16, 2017

Conversation

nicksnyder
Copy link
Contributor

This prevents the returned promises from prematurely resolving before the command finishes.

@joaomoreno joaomoreno merged commit 7e78566 into microsoft:master Oct 16, 2017
@joaomoreno
Copy link
Member

Great catches. Thanks! 🍻

@joaomoreno joaomoreno added this to the October 2017 milestone Oct 16, 2017
@joaomoreno joaomoreno added the git GIT issues label Oct 16, 2017
@nicksnyder nicksnyder deleted the scmawait branch October 16, 2017 13:17
@felixfbecker
Copy link
Contributor

There is a TSLint rule that can catch this: https://palantir.github.io/tslint/rules/no-floating-promises/
It does not trigger if the Promise is returned, awaited or has an error handler.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants