New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windowOpenNoOpener not opening new window #36857

Merged
merged 2 commits into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@misoguy
Contributor

misoguy commented Oct 25, 2017

Fix newTab returning null and not opening new window in windowOpenNoOpener
Encountered while testing PR #36795
@alexandrudima It would be best if you could take a look since it seems that this code was introduced on the commit 914c81e
Thank you :)

@alexandrudima

This comment has been minimized.

Show comment
Hide comment
@alexandrudima

alexandrudima Oct 25, 2017

Member

Thank you @misoguy! ❤️

Member

alexandrudima commented Oct 25, 2017

Thank you @misoguy! ❤️

@alexandrudima alexandrudima merged commit dd39b41 into Microsoft:master Oct 25, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.

@alexandrudima alexandrudima added this to the October 2017 milestone Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment