New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3422 Add Region folding for bat #36911

Merged
merged 2 commits into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@MichielVanderlee
Contributor

MichielVanderlee commented Oct 25, 2017

#3422
Add ::#region, ::#endregion and REM #region, REM #endregion folding markers for bat

MichielVanderlee added some commits Oct 25, 2017

@KillyMXI

This comment has been minimized.

Show comment
Hide comment
@KillyMXI

KillyMXI Oct 25, 2017

Contributor

"^\\s*(::|REM)\\s*#region"
This could match for invalid sequence REM#region.

Possible alternatives:
"^\\s*(::|REM\\s?)\\s*#region"
"^\\s*(::\\s*|REM\\s+)#region"

Contributor

KillyMXI commented Oct 25, 2017

"^\\s*(::|REM)\\s*#region"
This could match for invalid sequence REM#region.

Possible alternatives:
"^\\s*(::|REM\\s?)\\s*#region"
"^\\s*(::\\s*|REM\\s+)#region"

@aeschli aeschli merged commit ef38f54 into Microsoft:master Oct 26, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
@aeschli

This comment has been minimized.

Show comment
Hide comment
@aeschli

aeschli Oct 26, 2017

Contributor

Thanks @MichielVanderlee !
@KillyMXI Thanks for the suggestions. I applied your second proposal.

Contributor

aeschli commented Oct 26, 2017

Thanks @MichielVanderlee !
@KillyMXI Thanks for the suggestions. I applied your second proposal.

@aeschli aeschli added this to the October 2017 milestone Oct 26, 2017

aeschli added a commit that referenced this pull request Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment