New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #36924. PowerShell Extension Comment Highlighting Error #36926

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@ThmsRynr
Contributor

ThmsRynr commented Oct 25, 2017

Fixes issue #36924 to correct a comment highlighting error in the PowerShell extension. Now when the # is escaped with a backtick, therefore not creating a comment, the remainder of the line will not be highlighted as though it were a comment.

Code to reproduce

(($message.description | Select-Object -ExpandProperty `#cdata-section) -replace '(<\/*\w+?>){1,}','').trim()

Result before applying this change

image
This line has incorrect syntax highlighting. The backtick should escape the # and negate the syntax highlighting that colors the remainder of the line green.

Result after applying this change

image

Fix #36924. PowerShell Extension Comment Highlighting Error
Fixes issue #36924 to correct a comment highlighting error in the PowerShell extension.

@daviwil daviwil self-requested a review Oct 25, 2017

@daviwil

Looks good, thanks Thomas!

@aeschli aeschli merged commit 9e806c8 into Microsoft:master Oct 26, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
@aeschli

This comment has been minimized.

Show comment
Hide comment
@aeschli

aeschli Oct 26, 2017

Contributor

thanks @ThmsRynr !

Contributor

aeschli commented Oct 26, 2017

thanks @ThmsRynr !

@aeschli aeschli added this to the October 2017 milestone Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment