New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix different error message in source and package.nls for npm package #37096

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@qcz
Contributor

qcz commented Oct 29, 2017

No description provided.

qcz added some commits Oct 29, 2017

Fix package.nls.json for npm
Error message was different in main.ts.

@egamma egamma merged commit a05e3d9 into Microsoft:master Oct 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@egamma

This comment has been minimized.

Show comment
Hide comment
@egamma

egamma Oct 31, 2017

Member

@qcz Thanks for the fix!

Member

egamma commented Oct 31, 2017

@qcz Thanks for the fix!

@qcz qcz deleted the qcz:patch-4 branch Oct 31, 2017

egamma added a commit that referenced this pull request Oct 31, 2017

Fix different error message in source and package.nls for npm package (
#37096)

* Fix package.nls.json for npm

Error message was different in main.ts.

* Fix language string key in npm/src/main.ts
@qcz

This comment has been minimized.

Show comment
Hide comment
@qcz

qcz Nov 6, 2017

Contributor

@egamma: This PR is missing from the Thank You section of v1_18.md :)

Contributor

qcz commented Nov 6, 2017

@egamma: This PR is missing from the Thank You section of v1_18.md :)

@egamma egamma added this to the October 2017 milestone Nov 6, 2017

@egamma

This comment has been minimized.

Show comment
Hide comment
@egamma

egamma Nov 6, 2017

Member

@qcz sorry, I forgot to assing a milestone to the PR, this is why we didn't find it. I will add it.

Member

egamma commented Nov 6, 2017

@qcz sorry, I forgot to assing a milestone to the PR, this is why we didn't find it. I will add it.

@qcz

This comment has been minimized.

Show comment
Hide comment
@qcz

qcz Nov 6, 2017

Contributor

@egamma: No problem! Thanks!

Contributor

qcz commented Nov 6, 2017

@egamma: No problem! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment