New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing integrated terminal font-size overflow #37636

merged 1 commit into from Nov 6, 2017


None yet
2 participants

shobhitchittora commented Nov 4, 2017

This puts a maximum limit to allowed font-size for integrated terminal in VSCode.


  • No errors in build on local (npm run watch)
  • Tried putting large value such as "terminal.integrated.fontSize" : 1500 in OSS Dev VSCode.

Fixes #37455


Tyriar approved these changes Nov 6, 2017

Looks great! Thanks for the contribution 👍

@Tyriar Tyriar merged commit ccb0064 into Microsoft:master Nov 6, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
license/cla All CLA requirements met.

shobhitchittora added a commit to shobhitchittora/vscode that referenced this pull request Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment