New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging snippets for Javascript & typescript #37889

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
4 participants
@abinavseelan
Contributor

abinavseelan commented Nov 9, 2017

Add logging snippets for Javascript & Typescript

This PR addresses #37839 馃槃

Context

One nifty set of snippets that I do miss from my time with Atom are the log, warn and error snippets for Javascript.

log => console.log()
warn => console.warn()
error => console.error()

atom-log-snippets

Changes

  • Added new log, warn and error snippets to extensions/javascript/snippets/javascript.json
  • Added new warn and error snippets to extensions/typescript/snippets/typescript.json

After Changes

code-logging-snippet

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Nov 9, 2017

CLA assistant check
All CLA requirements met.

msftclas commented Nov 9, 2017

CLA assistant check
All CLA requirements met.

@auchenberg

This comment has been minimized.

Show comment
Hide comment
@auchenberg

auchenberg Nov 9, 2017

Contributor

@egamma @mattbierner How do we usually balance built-in snippets vs extension provided?

Contributor

auchenberg commented Nov 9, 2017

@egamma @mattbierner How do we usually balance built-in snippets vs extension provided?

@mjbvz

This comment has been minimized.

Show comment
Hide comment
@mjbvz

mjbvz Nov 9, 2017

Contributor

@auchenberg My idea for what should be a built-in snippet:

  • Useful for a large number of developers
  • Not framework or pattern specific
  • Meaningfully improves writing code and does not get in the way

This one fits the first two well. As for the third, these snippets are not a huge improvement over suggestions IMO but I do think they are a nice quality of life addition

Contributor

mjbvz commented Nov 9, 2017

@auchenberg My idea for what should be a built-in snippet:

  • Useful for a large number of developers
  • Not framework or pattern specific
  • Meaningfully improves writing code and does not get in the way

This one fits the first two well. As for the third, these snippets are not a huge improvement over suggestions IMO but I do think they are a nice quality of life addition

@mjbvz mjbvz merged commit 2a8744f into Microsoft:master Nov 10, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@mjbvz mjbvz added this to the November 2017 milestone Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment