New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make v8-profiler, css-parser URI http-proxy friendly #38181

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
4 participants
@nehaljwani
Contributor

nehaljwani commented Nov 13, 2017

No description provided.

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Nov 13, 2017

CLA assistant check
All CLA requirements met.

msftclas commented Nov 13, 2017

CLA assistant check
All CLA requirements met.

@jrieken

This comment has been minimized.

Show comment
Hide comment
@jrieken

jrieken Nov 13, 2017

Member

Can you elaborate a little on this?

Member

jrieken commented Nov 13, 2017

Can you elaborate a little on this?

@nehaljwani

This comment has been minimized.

Show comment
Hide comment
@nehaljwani

nehaljwani Nov 13, 2017

Contributor

On a machine behind corporate proxy:

(vscode) [nwani@machine vscode ] (master)$ node --version
v8.9.1

(vscode) [nwani@machine vscode ] (master)$ npm --version
5.5.1

(vscode) [nwani@machine vscode ] (master)$ env | grep -i proxy
https_proxy=http://proxy.my-corporate.com:3128

(vscode) [nwani@machine vscode ] (master)$ ./scripts/npm.sh install --arch=x64

> code-oss-dev@1.19.0 preinstall /spare/scratch/1510575918/vscode
> node build/npm/preinstall.js

npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!
npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t git://github.com/jrieken/v8-profiler.git
npm ERR! 
npm ERR! fatal: unable to connect to github.com:
npm ERR! github.com[0: 192.30.253.113]: errno=Connection refused
npm ERR! github.com[1: 192.30.253.112]: errno=Connection refused
npm ERR! 
npm ERR! 
npm ERR! exited with error code: 128

^C^C^C

Now apply this patch and npm succeeds

(vscode) [nwani@machine vscode ] (master)$ sed -i 's,git://,git+https://,' npm-shrinkwrap.json 

(vscode) [nwani@machine vscode ] (master *)$ git diff
diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
index 203fa2d..d0014ac 100644
--- a/npm-shrinkwrap.json
+++ b/npm-shrinkwrap.json
@@ -544,7 +544,7 @@
     "v8-profiler": {
       "version": "5.6.5",
       "from": "jrieken/v8-profiler#vscode",
-      "resolved": "git://github.com/jrieken/v8-profiler.git#5e4a336693e1d5b079c7aecd286a1abcfbc10421"
+      "resolved": "git+https://github.com/jrieken/v8-profiler.git#5e4a336693e1d5b079c7aecd286a1abcfbc10421"
     },
     "vscode-debugprotocol": {
       "version": "1.24.0",

(vscode) [nwani@machine vscode ] (master *)$ ./scripts/npm.sh install --arch=x64

> code-oss-dev@1.19.0 preinstall /spare/scratch/1510575918/vscode
> node build/npm/preinstall.js

npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
npm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated to-iso-string@0.0.2: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated minimatch@0.2.12: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

> typechecker@2.0.8 preinstall /spare/scratch/1510575918/vscode/node_modules/typechecker
> node ./cyclic.js


> oniguruma@6.1.1 install /spare/scratch/1510575918/vscode/node_modules/oniguruma
> node-gyp rebuild
Contributor

nehaljwani commented Nov 13, 2017

On a machine behind corporate proxy:

(vscode) [nwani@machine vscode ] (master)$ node --version
v8.9.1

(vscode) [nwani@machine vscode ] (master)$ npm --version
5.5.1

(vscode) [nwani@machine vscode ] (master)$ env | grep -i proxy
https_proxy=http://proxy.my-corporate.com:3128

(vscode) [nwani@machine vscode ] (master)$ ./scripts/npm.sh install --arch=x64

> code-oss-dev@1.19.0 preinstall /spare/scratch/1510575918/vscode
> node build/npm/preinstall.js

npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!
npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t git://github.com/jrieken/v8-profiler.git
npm ERR! 
npm ERR! fatal: unable to connect to github.com:
npm ERR! github.com[0: 192.30.253.113]: errno=Connection refused
npm ERR! github.com[1: 192.30.253.112]: errno=Connection refused
npm ERR! 
npm ERR! 
npm ERR! exited with error code: 128

^C^C^C

Now apply this patch and npm succeeds

(vscode) [nwani@machine vscode ] (master)$ sed -i 's,git://,git+https://,' npm-shrinkwrap.json 

(vscode) [nwani@machine vscode ] (master *)$ git diff
diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
index 203fa2d..d0014ac 100644
--- a/npm-shrinkwrap.json
+++ b/npm-shrinkwrap.json
@@ -544,7 +544,7 @@
     "v8-profiler": {
       "version": "5.6.5",
       "from": "jrieken/v8-profiler#vscode",
-      "resolved": "git://github.com/jrieken/v8-profiler.git#5e4a336693e1d5b079c7aecd286a1abcfbc10421"
+      "resolved": "git+https://github.com/jrieken/v8-profiler.git#5e4a336693e1d5b079c7aecd286a1abcfbc10421"
     },
     "vscode-debugprotocol": {
       "version": "1.24.0",

(vscode) [nwani@machine vscode ] (master *)$ ./scripts/npm.sh install --arch=x64

> code-oss-dev@1.19.0 preinstall /spare/scratch/1510575918/vscode
> node build/npm/preinstall.js

npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
npm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated to-iso-string@0.0.2: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated minimatch@0.2.12: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

> typechecker@2.0.8 preinstall /spare/scratch/1510575918/vscode/node_modules/typechecker
> node ./cyclic.js


> oniguruma@6.1.1 install /spare/scratch/1510575918/vscode/node_modules/oniguruma
> node-gyp rebuild
@nehaljwani

This comment has been minimized.

Show comment
Hide comment
@nehaljwani

nehaljwani Nov 13, 2017

Contributor

This is similar to the change: 87c476a

Contributor

nehaljwani commented Nov 13, 2017

This is similar to the change: 87c476a

@nehaljwani nehaljwani changed the title from Make v8-profiler URI http-proxy friendly to Make v8-profiler, css-parser URI http-proxy friendly Nov 13, 2017

@ramya-rao-a ramya-rao-a added this to the November 2017 milestone Nov 13, 2017

@ramya-rao-a

This comment has been minimized.

Show comment
Hide comment
@ramya-rao-a
Member

ramya-rao-a commented Nov 13, 2017

Thanks @nehaljwani

@ramya-rao-a ramya-rao-a merged commit ecb2beb into Microsoft:master Nov 13, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment