Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes markdown link syntax highlighting bug #38328

Merged
merged 1 commit into from Nov 14, 2017

Conversation

@shivammittal99
Copy link
Contributor

shivammittal99 commented Nov 14, 2017

Fixes Issue: #38049

Removed the optional space in regexp for the link markdown

Issue: #38049

Signed-off-by: Shivam Mittal <shivammittal99@gmail.com>
@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 14, 2017

CLA assistant check
All CLA requirements met.

@mjbvz mjbvz added this to the November 2017 milestone Nov 14, 2017
@mjbvz mjbvz merged commit 5fd4061 into microsoft:master Nov 14, 2017
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Nov 14, 2017

Thanks! Fix will be in the next insiders build

@shivammittal99 shivammittal99 deleted the shivammittal99:markdown-bug branch Nov 14, 2017
mjbvz added a commit that referenced this pull request Nov 14, 2017
This reverts commit 5fd4061.
mjbvz added a commit that referenced this pull request Nov 14, 2017
This reverts commit 5fd4061.
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Nov 14, 2017

Sorry, this change things and had to be reverted. The problem is that when the regexp capture group was deleted, we also need to shift all the capture indices after it down. I will take a quick look into fixing this

mjbvz added a commit that referenced this pull request Nov 14, 2017
Fixes #38049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.