New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quiet Light theme's JSX #39451

Merged
merged 4 commits into from Dec 4, 2017

Conversation

Projects
None yet
4 participants
@ajitid
Contributor

ajitid commented Dec 2, 2017

Fixes #39449 and #39460
This PR makes JSX to match with HTML colors and changes attribute color of HTML for visibility

JSX-HTML matching ->
Earlier:
33511050-6ab4ad92-d73a-11e7-866a-8f46975120fa

Now:
screenshot from 2017-12-02 09-10-33

HTML:
html

Attribute color improvement->
Earlier
screenshot from 2017-12-02 15-14-24

Now
screenshot from 2017-12-02 15-20-15

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Dec 2, 2017

CLA assistant check
All CLA requirements met.

msftclas commented Dec 2, 2017

CLA assistant check
All CLA requirements met.

ajitid added some commits Dec 2, 2017

@Ramaqmar

This comment has been minimized.

Show comment
Hide comment
@Ramaqmar

Ramaqmar Dec 3, 2017

], 



		"settings": { 



			"fontStyle": "italic", 
  •   		"foreground": "#7C98BB" 
    
  •   		"foreground": "#8190A0" 
    
    
    
      	} 
    
    
    
      }, 
    
    
    
      { 
    

Ramaqmar commented on a5fa08e Dec 3, 2017

], 



		"settings": { 



			"fontStyle": "italic", 
  •   		"foreground": "#7C98BB" 
    
  •   		"foreground": "#8190A0" 
    
    
    
      	} 
    
    
    
      }, 
    
    
    
      { 
    

@aeschli aeschli merged commit 509a568 into Microsoft:master Dec 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@aeschli

This comment has been minimized.

Show comment
Hide comment
@aeschli

aeschli Dec 4, 2017

Contributor

Thanks @ajitid !

Contributor

aeschli commented Dec 4, 2017

Thanks @ajitid !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment