Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support current user install of Git Bash #39674

Merged
merged 3 commits into from Dec 12, 2017
Merged

Support current user install of Git Bash #39674

merged 3 commits into from Dec 12, 2017

Conversation

njbmartin
Copy link
Contributor

Fixes #39671

@njbmartin njbmartin changed the title Support local install of Git Bash Support current user install of Git Bash Dec 6, 2017
@Tyriar
Copy link
Member

Tyriar commented Dec 11, 2017

Looks good, my only concern is that it %LOCALAPPDATA% points to the Local folder:

> process.env['LOCALAPPDATA']
"C:\Users\daimms.REDMOND\AppData\Local"

But in #39671 you say it's installed to Local\Programs? Please verify the default install location 😃

@Tyriar Tyriar added this to the December 2017 milestone Dec 11, 2017
@njbmartin
Copy link
Contributor Author

@Tyriar Good spot. Can't believe I did such a bad job of copy pasta. 🍝

I simply replaced ProgramFiles with LocalAppData. when I duplicated ${process.env['ProgramFiles']}\\Git\\usr\\bin\\bash.exe 👎

To back up this PR, please find the following references to the correct location:
#10810
kimmobrunfeldt/spawn-default-shell#6

@Tyriar
Copy link
Member

Tyriar commented Dec 12, 2017

Just wanted to check 😄 Thanks for the contribution! 🎆

@Tyriar Tyriar merged commit ceea046 into microsoft:master Dec 12, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git Bash missing from integrated terminal default choices
2 participants