Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench: Adds 'Show Code Version' Action #40745

Merged

Conversation

@shobhitchittora
Copy link
Contributor

shobhitchittora commented Dec 23, 2017

Fixes: #40574

@shobhitchittora

This comment has been minimized.

Copy link
Contributor Author

shobhitchittora commented Dec 23, 2017

@joaomoreno Please review this 😇.

@weinand weinand requested a review from bpasero Dec 23, 2017
@weinand weinand requested review from joaomoreno and removed request for bpasero Dec 23, 2017
@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Dec 23, 2017

@shobhitchittora can I ask, why not simply show the about dialog that includes the version?

@shobhitchittora

This comment has been minimized.

Copy link
Contributor Author

shobhitchittora commented Dec 23, 2017

This is as per suggestion from @joaomoreno in the issue thread. Also I think here the intent is just show version number and not any additional info, thus adding as a Command.

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Dec 27, 2017

@shobhitchittora @joaomoreno I would prefer a command that simply shows the about dialog

@shobhitchittora

This comment has been minimized.

Copy link
Contributor Author

shobhitchittora commented Dec 28, 2017

@joaomoreno @bpasero I found the below function which open the About dialog from menu bar items.
https://github.com/Microsoft/vscode/blob/c5669a2520f3fc2cb7a0ecb97c47cdd2de4f9d33/src/vs/code/electron-main/menus.ts#L1201
Is it possible to invoke this by registering a new Action in the registry?

@bpasero bpasero assigned joaomoreno and unassigned bpasero Dec 28, 2017
@shobhitchittora

This comment has been minimized.

Copy link
Contributor Author

shobhitchittora commented Jan 5, 2018

Ping @joaomoreno . Any follow-ups on this?

@joaomoreno joaomoreno added this to the Backlog milestone Jan 8, 2018
@joaomoreno joaomoreno added the workbench label Jan 8, 2018
@bpasero bpasero removed the workbench label Jan 11, 2018
@joaomoreno joaomoreno added the workbench label Feb 9, 2018
@joaomoreno joaomoreno modified the milestones: Backlog, February 2018 Feb 9, 2018
@joaomoreno joaomoreno merged commit 368785b into microsoft:master Feb 9, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Feb 9, 2018

@shobhitchittora Thanks for the contribution! 🍻

Sorry for not getting back earlier. I've renamed the command to Help: About. I've moved it to another contribution file. I've also changed the implementation to what @bpasero suggested.

@shobhitchittora

This comment has been minimized.

Copy link
Contributor Author

shobhitchittora commented Feb 9, 2018

Awesome ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.