New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeleteAllLeft when executed from column 1 #40876

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@msftclas

This comment has been minimized.

msftclas commented Dec 27, 2017

CLA assistant check
All CLA requirements met.

@Tyriar Tyriar requested a review from rebornix Dec 27, 2017

@rebornix rebornix added this to the February 2018 milestone Jan 30, 2018

@bpasero bpasero modified the milestones: February 2018, March 2018 Mar 8, 2018

@bpasero bpasero modified the milestones: March 2018, April 2018 Apr 6, 2018

@bpasero bpasero modified the milestones: April 2018, May 2018 May 8, 2018

@spalger spalger changed the title from Delete line when DeleteAllLeft executed at column 1 to Fix DeleteAllLeft when executed from column 1 May 16, 2018

@bpasero bpasero modified the milestones: May 2018, June 2018 Jun 7, 2018

@spalger

This comment has been minimized.

spalger commented Jun 12, 2018

This change is really small, tested, and very meaningful to me 😄

@rebornix

This comment has been minimized.

Member

rebornix commented Jun 12, 2018

I don't know why I still didn't merge this PR, will take a look.

@rebornix

This comment has been minimized.

Member

rebornix commented Jun 19, 2018

@spalger thanks for your great effort, there are several corner cases, like multi cursor, not handled perfectly. #28392 addresses issue so I merged that pr. Sorry for not merging this one, thanks anyways for your contribution.

@rebornix rebornix closed this Jun 19, 2018

@spalger

This comment has been minimized.

spalger commented Jun 19, 2018

Fantastic, that works for me! Thanks @rebornix!

@spalger spalger deleted the spalger:fix/16460 branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment