New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify check lang.mimetypes #42932

Merged
merged 1 commit into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@Connormiha
Copy link
Contributor

Connormiha commented Feb 4, 2018

This PR simplify mergeLanguage

  1. Remove needless check for type undefined, because Array.isArray doesn't pass undefined, null, etc.
  2. Get rid of for loop and use native push + spread
  3. Don't check primaryMime in each step. Just pull from first element.

@alexandrudima alexandrudima self-assigned this Feb 5, 2018

@alexandrudima alexandrudima added this to the March 2018 milestone Mar 26, 2018

@alexandrudima alexandrudima merged commit 5267caa into Microsoft:master Mar 26, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment