Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19580; added copy property path action to debug viewlet #43423

Merged
merged 2 commits into from Feb 14, 2018

Conversation

@ergunsh
Copy link
Contributor

ergunsh commented Feb 11, 2018

Fixes #19580

@msftclas

This comment has been minimized.

Copy link

msftclas commented Feb 11, 2018

CLA assistant check
All CLA requirements met.

static LABEL = nls.localize('copyPropertyPath', "Copy Property Path");

constructor(id: string, label: string, private value: any) {
super(id, label, 'debug-action copy-property-path');

This comment has been minimized.

Copy link
@isidorn

isidorn Feb 13, 2018

Contributor

No need to pass the css class since this action does not have that, simply pass undefined as the third argument

@@ -34,6 +34,23 @@ export class CopyValueAction extends Action {
}
}

export class CopyPropertyPathAction extends Action {

This comment has been minimized.

Copy link
@isidorn

isidorn Feb 13, 2018

Contributor

CopyEvaluatePathAction is a better name imho

@@ -34,6 +34,23 @@ export class CopyValueAction extends Action {
}
}

export class CopyPropertyPathAction extends Action {
static readonly ID = 'workbench.debug.viewlet.action.copyPropertyPath';

This comment has been minimized.

Copy link
@isidorn

isidorn Feb 13, 2018

Contributor

Change id to workbench.debug.viewlet.action.copyEvaluatePath'

export class CopyPropertyPathAction extends Action {
static readonly ID = 'workbench.debug.viewlet.action.copyPropertyPath';
static LABEL = nls.localize('copyPropertyPath', "Copy Property Path");

This comment has been minimized.

Copy link
@isidorn

isidorn Feb 13, 2018

Contributor

I would change the label to "Copy Path"

@@ -179,6 +179,7 @@ class VariablesActionProvider implements IActionProvider {
const actions: IAction[] = [];
const variable = <Variable>element;
actions.push(new SetValueAction(SetValueAction.ID, SetValueAction.LABEL, variable, this.debugService, this.keybindingService));
actions.push(new CopyPropertyPathAction(CopyPropertyPathAction.ID, CopyPropertyPathAction.LABEL, variable));

This comment has been minimized.

Copy link
@isidorn

isidorn Feb 13, 2018

Contributor

Set Value and Copy Value should be first, So CopyEvaluatePathAction should come third

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Feb 13, 2018

@ergun1017 I have commented directly in the code - mostly polish. Once you address all those I can merge this in. Thanks

@isidorn isidorn merged commit 67ea7f6 into microsoft:master Feb 14, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@isidorn isidorn added this to the February 2018 milestone Feb 14, 2018
@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Feb 14, 2018

@ergun1017 good job, thanks a lot 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.