Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #43465 #44006
We could rearrange the dom nodes in https://github.com/Microsoft/vscode/blob/ab7f6e871d1af714ae454a06e2745a6ec0521704/src/vs/editor/browser/view/viewImpl.ts#L227:L234
But now I am having second thoughts if we should do this change at all:
Here is the case where scrolling to the right, the minimap also drops a shadow, and the top shadow and the right shadow form a nice corner at the minimap boundary. With this change things would not line up:
@alexandrudima From my understanding, if the minimap is on the right side, everything seems to be fine. If the minimap is on the left side, there are two issues.
This PR seems to fix issue 1 (the top shadow) by increasing the width of the shadow.
I think we should add the shadow on the right side by sticking it to the vertical scrollbar. And I think it might require a separate issue.
@aushakou Sorry about that. I somehow misunderstood the issue, and didn't place the minimap to the left.
May I suggest we do the following:
When the minimap is to the left, we make the right-hand side area of the editor behave as if the minimap is disabled. Namely: