New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php grammar update script #44171

Merged
merged 2 commits into from Mar 8, 2018

Conversation

Projects
None yet
4 participants
@mathsalmi
Copy link
Contributor

mathsalmi commented Feb 22, 2018

This PR fixes #44032.

On a side note: I don't think we need the workaround applied in the update-grammar.js file anymore. I've opened some PHP files and it worked perfectly with Atom's regex (different from what was reported on #59 and #40279).

However, as I didn't test further, I decided to keep the workaround and just fix its regex.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Feb 22, 2018

CLA assistant check
All CLA requirements met.

@duttaditya18
Copy link

duttaditya18 left a comment

Ayee! Looks good! 👍

@roblourens roblourens added this to the March 2018 milestone Feb 25, 2018

@roblourens
Copy link
Member

roblourens left a comment

Thanks! Great find!

@roblourens roblourens merged commit 24d376c into Microsoft:master Mar 8, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment