New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled 'Open to the side' command only for files #44968

Merged
merged 2 commits into from Mar 5, 2018

Conversation

Projects
None yet
3 participants
@oriash93
Copy link
Contributor

oriash93 commented Mar 3, 2018

I'm not totally sure if that's the optimal solution, but it works for markdown preview files (as stated in the issue) and for the Welcome page (which acts the same).

resolves #44676

@mjbvz mjbvz requested a review from bpasero Mar 5, 2018

@bpasero bpasero requested review from isidorn and removed request for bpasero Mar 5, 2018

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Mar 5, 2018

@oriash93 thanks for your PR. I think this makes sense as the current wlecome page and the open to the side do not work. So let's disable it for now.
However the .isFile is a subset of has resource, so I will change your .and clause to simply be isFIle 9e6944d

@isidorn isidorn merged commit f9dbfb4 into Microsoft:master Mar 5, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@isidorn isidorn added this to the March 2018 milestone Mar 5, 2018

@isidorn isidorn self-assigned this Mar 5, 2018

@oriash93

This comment has been minimized.

Copy link
Contributor

oriash93 commented Mar 5, 2018

Did not know that, always good to learn.
Thanks!

@oriash93 oriash93 deleted the oriash93:oriash93/44676 branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment