Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move huge file params to user config for Microsoft/vscode#44986 and mechatroner/vscode_rainbow_csv#3 #44988

Merged
merged 5 commits into from Apr 9, 2018

Conversation

@mechatroner
Copy link
Contributor

commented Mar 3, 2018

I've tested this and it is fixing #44986 and mechatroner/vscode_rainbow_csv#3
If passing two parameters (hugeFileSize and hugeFileNumLines) around looks too bad, I can replace them with a single allowHugeFileSyntax which would be false by default.

@msftclas

This comment has been minimized.

Copy link

commented Mar 3, 2018

CLA assistant check
All CLA requirements met.

@alexandrudima alexandrudima added this to the March 2018 milestone Mar 5, 2018

@bpasero bpasero modified the milestones: March 2018, April 2018 Apr 6, 2018

@alexandrudima

This comment has been minimized.

Copy link
Member

commented Apr 9, 2018

👍 Thank you!

@alexandrudima alexandrudima merged commit fbe4d37 into microsoft:master Apr 9, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.