New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive comment string matching #44998

Merged
merged 1 commit into from Mar 26, 2018

Conversation

Projects
None yet
2 participants
@oriash93
Copy link
Contributor

oriash93 commented Mar 4, 2018

resolves #35589

@oriash93 oriash93 force-pushed the oriash93:oriash93/35589 branch from c6ea9f5 to 20d7819 Mar 4, 2018

@alexandrudima

This comment has been minimized.

Copy link
Member

alexandrudima commented Mar 5, 2018

@oriash93 I don't know if this is true for all programming languages... But not a lot of programming languages use ASCII for comments either, so it might just work...

@oriash93 oriash93 force-pushed the oriash93:oriash93/35589 branch from 20d7819 to 857d545 Mar 6, 2018

@oriash93

This comment has been minimized.

Copy link
Contributor

oriash93 commented Mar 6, 2018

@alexandrudima Here is a comparison of comments in some programming languages..
As you can see, some do contain alphabetic characters. Are they relevant to vscode? If these cases worth considering a different solution, let me know.

@alexandrudima alexandrudima added this to the March 2018 milestone Mar 18, 2018

@alexandrudima alexandrudima merged commit 939ae9e into Microsoft:master Mar 26, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@oriash93 oriash93 deleted the oriash93:oriash93/35589 branch Apr 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment