New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted icon size #45608

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@chryw
Copy link
Member

chryw commented Mar 12, 2018

#45432
@isidorn

  • "Continue/Debug" icon is now about the same size as the "Stop" icon
  • Reduced base size for all debug icons in editor margin and viewlet.
    image
Adjusted breakpoint icon size to fit default editor line height beter…
…; Adjusted debug green arrow icon size to match stop icon.

@isidorn isidorn added this to the March 2018 milestone Mar 13, 2018

@isidorn isidorn merged commit 5647bc8 into Microsoft:master Mar 13, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Mar 13, 2018

@chryw I just tried it out and the sizes are great. Everything in the debug toolbar looks perfectly fitting.
I just have 3 pieces of feedback:

  • current-and-brekapoint.svg and stackframe-and-breakpoint.svg are not correct, since they only have the arrow, not the red breakpoint dot
  • With the new breakpoint size the conditional breakpoint icon does not really work since the equality lines are too far apart (this can also be seen in your screenshot on the BREAKPOINTS view)
  • The new breakpoint size makes the breakpoints looks more square like, and not like a perfect circle. I am not sure if this is just me or the shape of the breakpoint also changed, not only the size?
    screen shot 2018-03-13 at 10 00 47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment