New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set electron version in env scripts #45696

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
2 participants
@stevedesmond-ca
Copy link
Contributor

stevedesmond-ca commented Mar 13, 2018

Since the console.log() got removed from build/lib/electron.js, the npm_config_target environment variable wasn't getting set to anything.

This PR updates the scripts to call the getElectronVersion() method on build/lib/electron.js.

@joaomoreno joaomoreno merged commit 13f3c4d into Microsoft:master Mar 14, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Mar 14, 2018

Oh wow. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment