New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21423 | Add ANSI colour tokens as children of existing tokens #45946

Merged
merged 1 commit into from Mar 19, 2018

Conversation

Projects
None yet
3 participants
@danielfrankcom
Copy link
Contributor

danielfrankcom commented Mar 16, 2018

#21423

Previous implementation was appending new <span> elements to the same node, rather than finding the deepest node each time and appending to that. I added a loop to find the deepest child and append, ensuring that new tokens are nested as desired.

@isidorn isidorn assigned isidorn and unassigned egamma Mar 19, 2018

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Mar 19, 2018

Thanks for your great PR 🍻
Seems to work nicely, even though on my mac the bold is not that strong but that is by browser design. Let's merge this in and get user feedback

@isidorn isidorn added the debug label Mar 19, 2018

@isidorn isidorn added this to the March 2018 milestone Mar 19, 2018

@isidorn isidorn merged commit bd251d6 into Microsoft:master Mar 19, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment