New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #46027 by using box-shadow css to render guides #46029

Merged
merged 2 commits into from Mar 26, 2018

Conversation

Projects
None yet
4 participants
@gizm0bill
Copy link

gizm0bill commented Mar 17, 2018

…rather than background color and computed width
Should also be faster without these computations
vscode-guides-fixed

Fixes #46027 by using box-shadow css to render guides, rather than ba…
…ckground color and computed width

...should also be faster without these computations
@msftclas

This comment has been minimized.

Copy link

msftclas commented Mar 17, 2018

CLA assistant check
All CLA requirements met.

@alexandrudima

This comment has been minimized.

Copy link
Member

alexandrudima commented Mar 26, 2018

This is very cool! Thank you! I will just push a follow-up commit to remove the usage of CSS variables, as this is not supported in IE11 (supported by the monaco editor)

@alexandrudima alexandrudima added this to the March 2018 milestone Mar 26, 2018

@alexandrudima alexandrudima merged commit d0ad42a into Microsoft:master Mar 26, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

alexandrudima added a commit that referenced this pull request Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment