New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary lines in .travis.yml #46044

Merged
merged 1 commit into from Mar 19, 2018

Conversation

Projects
None yet
2 participants
@amtlib-dot-dll
Copy link
Contributor

amtlib-dot-dll commented Mar 18, 2018

#46043

As Travis CI have nvm shipped in their images, there is no need to install nvm again

@amtlib-dot-dll

This comment has been minimized.

Copy link
Contributor

amtlib-dot-dll commented Mar 18, 2018

The removed lines does not affect the test result as is shown in the Travis log 🤔 The master branch won't pass the test at all

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Mar 19, 2018

Looks good! Thanks! 🍻

@joaomoreno joaomoreno added this to the March 2018 milestone Mar 19, 2018

@joaomoreno joaomoreno merged commit 8d5d595 into Microsoft:master Mar 19, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@amtlib-dot-dll amtlib-dot-dll deleted the amtlib-dot-dll:patch-1 branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment