New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #46075 #46227

Merged
merged 4 commits into from Mar 28, 2018

Conversation

Projects
None yet
2 participants
@AiryShift
Copy link
Contributor

AiryShift commented Mar 21, 2018

I've probably fixed the incorrect behaviour, in that non-edits should not add anything to the undo stack. However, the unit test which reproduce the bug as described in the issue, doesn't. That is to say if the commit that fixes the bug fe395f5 is reverted the test still passes. Could someone help point me in the right direction?

AiryShift added some commits Mar 21, 2018

Add test to check for 46075: NOT WORKING
This should reproduce the bug as described in #46075 but doesn't

@Tyriar Tyriar changed the title [WIP] Fixes $46075 [WIP] Fixes #46075 Mar 22, 2018

@alexandrudima alexandrudima changed the title [WIP] Fixes #46075 Fixes #46075 Mar 28, 2018

@alexandrudima

This comment has been minimized.

Copy link
Member

alexandrudima commented Mar 28, 2018

Thank you!

@alexandrudima alexandrudima merged commit 215d651 into Microsoft:master Mar 28, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.
Details

@alexandrudima alexandrudima added this to the March 2018 milestone Mar 28, 2018

@AiryShift AiryShift deleted the AiryShift:bug46075 branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment