New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to prevent fakeFireContinued when initiating time-travel #46441

Merged
merged 1 commit into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@mrkmarron
Copy link
Contributor

mrkmarron commented Mar 23, 2018

Based on discussion in issue #42384 I have heavily refactored the code to work almost entirely as an extension.

In this implementation clicking the step-back button when in "live" debug mode will launch a time-travel session. However, a fireFakeContinued still occurs and leaves the live session in an ill-defined state. This PR adds a check for these 2 cases and simply suppresses the fake event when needed. This is backward compatible with previous uses and only impacts the TTD specific code paths.

@weinand weinand added this to the March 2018 milestone Mar 23, 2018

@mrkmarron mrkmarron force-pushed the mrkmarron:innerloopchange branch from 8484514 to 054bc03 Mar 23, 2018

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Mar 26, 2018

@mrkmarron thanks for this PR.
I have reviewed and this makes sense to me, especially since this code path is only hit for the TTD specific cases.

@isidorn isidorn merged commit c663a76 into Microsoft:master Mar 26, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@weinand weinand added the debug label Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment