Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Terminal Command based on Workspace Path #45694 #46461

Merged
merged 2 commits into from Apr 2, 2018

Conversation

@knyhle
Copy link
Contributor

commented Mar 24, 2018

Add feature requested: #45694

Made Split Terminal work like the Create Terminal command including (In Active Workspace) option.

out

@msftclas

This comment has been minimized.

Copy link

commented Mar 24, 2018

CLA assistant check
All CLA requirements met.

@Tyriar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2018

Thanks @kennyle1412! I'll check this out soon for the April release as we're currently in endgame/testing for the March release. Could you fix the conflicts in the meantime?

@Tyriar Tyriar added this to the April 2018 milestone Mar 27, 2018

@knyhle knyhle force-pushed the knyhle:master branch from a0db194 to 5735b41 Mar 27, 2018

@knyhle

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2018

@Tyriar yeah, no problem! Take as long as you need.

@duttaditya18
Copy link

left a comment

Looks awesome!

knyhle added some commits Mar 24, 2018

Created Split Terminal (In Active Workspace)
Similar functionality to CreateTerminalInActiveWorkspace for
CreateTerminal for no prompt creation.

@knyhle knyhle force-pushed the knyhle:master branch from 5735b41 to 860073d Apr 2, 2018

@Tyriar

Tyriar approved these changes Apr 2, 2018

Copy link
Member

left a comment

@kennyle1412 really nice PR! 👍

@Tyriar Tyriar merged commit 97dcb55 into microsoft:master Apr 2, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.