Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a space between # and `region` for folding in Python #46885

Merged
merged 1 commit into from Apr 16, 2018

Conversation

@brettcannon
Copy link
Member

commented Mar 28, 2018

Automatic formatting inserts a space between the comment marker # and text in the Python extension, so without the allowance for whitespace then "editor.formatOnType": true breaks all region markers.

Closes microsoft/vscode-python#1073 and microsoft/vscode-python#33

Allow a space between # and `region` for folding in Python
Automatic formatting inserts a space between the comment marker `#` and text in the Python extension, so without the allowance for whitespace then `"editor.formatOnType": true` breaks all region markers.

Closes microsoft/vscode-python#1073 and microsoft/vscode-python#33

@aeschli aeschli added this to the April 2018 milestone Mar 29, 2018

@aeschli aeschli merged commit efd3ac4 into microsoft:master Apr 16, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
@aeschli

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2018

Thanks @brettcannon !

@brettcannon brettcannon deleted the brettcannon:patch-1 branch Apr 16, 2018

@brettcannon

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2018

@aeschli Welcome! Thanks for helping me close out 2 issues on our own repo. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.