Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTEGRATED-TERMINAL] Clear selection by pressing escape key #47042

Conversation

@ddruker
Copy link
Contributor

commented Mar 31, 2018

Overview

This PR will add a command that prevents the terminal window from placing the terminal prompt in view when the escape key is pressed and there is output selected.

Ref Microsoft/vscode#46728

Screenshots

  • The user can select and when escape is pressed, it will clear the selection. When there is no selection, it will default to normal behavior.

esc

@Tyriar Tyriar added this to the April 2018 milestone Apr 2, 2018

@Tyriar

This comment has been minimized.

Copy link
Member

commented Apr 2, 2018

@ddruker looks good! I commited a change to make the action name more consistent with the rest and also cover the case where the find widget is visible: when both the find widget and a selection is up, escape will close the find widget, another escape will clear the selection, another escape will send esc to the shell.

@Tyriar Tyriar merged commit 1289571 into microsoft:master Apr 2, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.