Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C# TextMate grammar with latest bug fixes #47520

Merged
merged 1 commit into from Apr 11, 2018

Conversation

@DustinCampbell
Copy link
Member

commented Apr 9, 2018

This PR includes the following fixes for the C# TextMate grammar:

Thanks to @Muchiachio for contributing these fixes!

Update C# TextMate grammar with latest bug fixes
This PR includes the following fixes for the C# TextMate grammar:

* Comments are now allowed after checked and unchecked statements
(dotnet/csharp-tmLanguage#104)
* 'dynamic' is now highlighted as a built-in type keyword (dotnet/csharp-tmLanguage#26)
* Single-line comments with four slashes (i.e. ////) are now highlighted properly
(dotnet/csharp-tmLanguage#100)

Thanks to (@Muchiachio](https://github.com/Muchiachio) for contributing these fixes!
@DustinCampbell

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2018

Looks a particular test exceeded it's timeout:

  3965 passing (1m)
  1 failing
  1) FileService updateContent - use encoding (UTF 16 BE):
     Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.

I suspect this is not related to my grammar-only change for C#.

@aeschli aeschli merged commit 71300ed into microsoft:master Apr 11, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.

@aeschli aeschli added this to the April 2018 milestone Apr 11, 2018

@aeschli

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2018

Thanks @DustinCampbell !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.