Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set background-color explicitly instead of shorthand declaration #47752 #47785

Merged
merged 1 commit into from Apr 13, 2018

Conversation

@fmal
Copy link
Contributor

commented Apr 12, 2018

see #47752. background shorthand has a side effect of setting all background properties including resetting background-image, which is set for dirty tabs.

Before:
screen shot 2018-04-13 at 00 08 07

After:
screen shot 2018-04-13 at 00 08 46

@bpasero bpasero self-assigned this Apr 13, 2018

@bpasero bpasero added this to the April 2018 milestone Apr 13, 2018

@bpasero

This comment has been minimized.

Copy link
Member

commented Apr 13, 2018

@fmal thanks 🥂

@bpasero bpasero merged commit 70f47d4 into microsoft:master Apr 13, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.