Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #33132: Regenerate php functions. #47865

Merged
merged 2 commits into from Apr 22, 2018

Conversation

@mattacosta
Copy link
Contributor

commented Apr 14, 2018

See #33132 (comment) for details.

@roblourens roblourens self-assigned this Apr 14, 2018

@roblourens roblourens added this to the April 2018 milestone Apr 14, 2018

@Loridawn99

This comment has been minimized.

@roblourens

This comment has been minimized.

Copy link
Member

commented Apr 15, 2018

Where is the manual.xml file? How can we update this again in the future?

@mattacosta

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2018

The best way to get the latest version is to just checkout a copy of the documentation:

svn co https://svn.php.net/repository/phpdoc/modules/doc-en doc-en

Then run doc-base/configure.php, which (by default) should give you a nice ~43MB file to play around with.

As for updating this again, that's a bit trickier since I didn't have whatever that php-exclude_generate_php_globals.js file was and had to edit a bit of code to get the proper format.

@roblourens

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

I see, I just don't follow how you actually generated the phpGlobalFunctions.ts this time. If you have a script that generates that file from the xml file, could we also check in that script?

@mattacosta

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2018

Yes, that is how I created it. I'll see about cleaning it up and eventually committing it somewhere too.

@roblourens roblourens merged commit b6a5170 into microsoft:master Apr 22, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@roblourens roblourens added the php label Apr 22, 2018

@mattacosta mattacosta deleted the mattacosta:mattacosta/regenerate-php-globals branch Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.