Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Hover#range to be optional #48004

Merged
merged 1 commit into from Apr 17, 2018

Conversation

@nikeee
Copy link
Contributor

commented Apr 16, 2018

The docs of Hover#range in monaco.d.ts and modes.ts state:

When missing, the editor will use the range at the current position or the current position itself.

This implies that the range field should be optional as it can be missing. When looking at the references to Hover#range, we find out that there might pop up warnings in modesContentHover.ts when vscode is compiled with strictNullChecks later.

Change Hover#range to be optional
The docs of `Hover#range` state:

> When missing, the editor will use the range at the current position or the current position itself.

This implies that the `range` field should be optional as it can be missing.
@jrieken

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

Looks good, merging but as said earlier: It is unlikely that monaco.d.ts. will properly support strict-null-checks because a good chunk of it is taken directly from our sources

@jrieken jrieken merged commit 54e5387 into microsoft:master Apr 17, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.

@jrieken jrieken added this to the April 2018 milestone Apr 17, 2018

@nikeee nikeee deleted the nikeee:patch-1 branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.