New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await git.pullFrom and gitt.pushTo to ensure any failures display an … #49167

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
5 participants
@chenhowa

chenhowa commented May 4, 2018

…error dialog to the user

@chenhowa chenhowa closed this May 4, 2018

@chenhowa chenhowa deleted the chenhowa:git-errors branch May 4, 2018

@chenhowa chenhowa restored the chenhowa:git-errors branch May 4, 2018

@chenhowa

This comment has been minimized.

chenhowa commented May 4, 2018

Refers to #41519.

@chenhowa

This comment has been minimized.

chenhowa commented May 4, 2018

This just adds two 'await' statements to ensure that if git.pushTo or git.pullFrom fail when using the Command Palette, the failure is not silent. Instead, the user is notified with an error dialog.

@chenhowa chenhowa reopened this May 4, 2018

@joaomoreno joaomoreno added the git label May 6, 2018

@joaomoreno joaomoreno added this to the Backlog milestone May 6, 2018

@@ -1333,7 +1333,7 @@ export class CommandCenter {
const remoteCharCnt = remotePick.label.length;
repository.pullFrom(false, remotePick.label, branchPick.label.slice(remoteCharCnt + 1));

This comment has been minimized.

@loridawn

This comment has been minimized.

@PowerAccess

PowerAccess Jun 17, 2018

Hi @loridawn,
Is this related to implementing #52116 ("Extension Permission Management, Updating, Security & Categories") or did you mean to reference another issue?

@joaomoreno joaomoreno merged commit 4e575be into Microsoft:master Jun 18, 2018

1 check passed

license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Member

joaomoreno commented Jun 18, 2018

Great fix! Thanks! 🍻

@joaomoreno joaomoreno modified the milestones: Backlog, June 2018 Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment