Skip to content

git: fix includeIf on Windows by uppercasing drive letter (#40354) - #50376

Closed
zhuowei wants to merge 1 commit into
microsoft:masterfrom
zhuowei:fix-includeif
Closed

zhuowei wants to merge 1 commit into
microsoft:masterfrom
zhuowei:fix-includeif

Conversation

@zhuowei

@zhuowei zhuowei commented May 24, 2018 •

Copy link
Copy Markdown
Contributor

This fixes #40354.

Git's includeIf feature by default matches the path against the current working directory in a case sensitive manner.

VS Code launches Git using a current working directory with a lowercase drive letter, while everything else uses an uppercase drive letter, so includeIf directives that work everywhere else don't work in VS Code.

This commit borrows the fix from #9448, which manually uppercases the drive letter for Windows.

…40354)

Git's includeIf feature by default matches the path against the current
working directory in a case sensitive manner.

VS Code launches Git using a current working directory with a lowercase
drive letter, while everything else uses an uppercase drive letter,
so includeIf directives that work everywhere else don't work in
VS Code.

This commit borrows the fix from microsoft#9448, which manually uppercases the
drive letter for Windows.
@joaomoreno

Copy link
Copy Markdown
Contributor

zhuowei Can you check why I can't use this feature? #40354 (comment)

@joaomoreno

João Moreno (joaomoreno) commented Sep 14, 2018 •

Copy link
Copy Markdown
Contributor

Closing due to #40354 (comment)

Thanks for the effort any way!

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

git GIT issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git integration does not correctly support includeIf directive

2 participants