New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: fix includeIf on Windows by uppercasing drive letter (#40354) #50376

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@zhuowei
Contributor

zhuowei commented May 24, 2018

This fixes #40354.

Git's includeIf feature by default matches the path against the current working directory in a case sensitive manner.

VS Code launches Git using a current working directory with a lowercase drive letter, while everything else uses an uppercase drive letter, so includeIf directives that work everywhere else don't work in VS Code.

This commit borrows the fix from #9448, which manually uppercases the drive letter for Windows.

git: fix includeIf on Windows by uppercasing drive letter (#40354)
Git's includeIf feature by default matches the path against the current
working directory in a case sensitive manner.

VS Code launches Git using a current working directory with a lowercase
drive letter, while everything else uses an uppercase drive letter,
so includeIf directives that work everywhere else don't work in
VS Code.

This commit borrows the fix from #9448, which manually uppercases the
drive letter for Windows.

@joaomoreno joaomoreno added this to the Backlog milestone May 28, 2018

@joaomoreno joaomoreno added the git label May 28, 2018

@joaomoreno

This comment has been minimized.

Member

joaomoreno commented Sep 13, 2018

@zhuowei Can you check why I can't use this feature? #40354 (comment)

@joaomoreno

This comment has been minimized.

Member

joaomoreno commented Sep 14, 2018

Closing due to #40354 (comment)

Thanks for the effort any way!

@joaomoreno joaomoreno closed this Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment