git: fix includeIf on Windows by uppercasing drive letter (#40354) #50376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…40354) Git's includeIf feature by default matches the path against the current working directory in a case sensitive manner. VS Code launches Git using a current working directory with a lowercase drive letter, while everything else uses an uppercase drive letter, so includeIf directives that work everywhere else don't work in VS Code. This commit borrows the fix from microsoft#9448, which manually uppercases the drive letter for Windows.
|
@zhuowei Can you check why I can't use this feature? #40354 (comment) |
|
Closing due to #40354 (comment) Thanks for the effort any way! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #40354.
Git's includeIf feature by default matches the path against the current working directory in a case sensitive manner.
VS Code launches Git using a current working directory with a lowercase drive letter, while everything else uses an uppercase drive letter, so includeIf directives that work everywhere else don't work in VS Code.
This commit borrows the fix from #9448, which manually uppercases the drive letter for Windows.