New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown and common toolbar icons consistency pass #50484

Merged
merged 5 commits into from Jun 3, 2018

Conversation

Projects
None yet
2 participants
@chryw
Member

chryw commented May 25, 2018

#50438
@misolori @bpasero
I did a consistency pass to some icons on the editor top right toolbar area.

  • visually aligned these icons
  • aligned svg code style (responsive, hide halo and foreground, etc.)
  • removed some unnecessary css styles so they don't override the global size of these icons

There might be other icons could show up in that area. I only tested below icons and made sure they look good. Please let me know if this change makes other icons inconsistent.

@bpasero bpasero added this to the May 2018 milestone May 26, 2018

@bpasero

@chryw the ellipsis icon seems a bit inconsistent now:

Search (new left, old right, seems to be smaller now):
image

Panel (new left, old right, seems to be much larger now):
image

@bpasero

This comment has been minimized.

Member

bpasero commented Jun 1, 2018

@chryw

This comment has been minimized.

Member

chryw commented Jun 1, 2018

@bpasero will fix today

chryw and others added some commits Jun 1, 2018

@bpasero bpasero merged commit 749a1bf into Microsoft:master Jun 3, 2018

1 of 2 checks passed

VSTS: VS Code 20180603.5 failed
Details
license/cla All CLA requirements met.
Details
@bpasero

This comment has been minimized.

Member

bpasero commented Jun 3, 2018

@chryw thanks, I merged this to master for our June release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment