New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar Injection - Consider broader Scopes #50534

Merged
merged 2 commits into from Nov 2, 2018

Conversation

Projects
None yet
2 participants
@AdrieanKhisbe
Copy link
Contributor

AdrieanKhisbe commented May 27, 2018

In order to be able in an extension to inject grammar to all languages without having to enumerate all of them, Consider broader Scopes in getInjections()

With this, we could use

"grammars": [
     {
     "injectTo": ["source", "text",....]
// ....
}
     ]

instead of :

"grammars": [
     {
     "injectTo": ["source.js", "source.ts", "source.jsx", "source.yaml", ....]
// ....
}
     ]
Grammar Injection - Consider broader Scopes
In order to be able to inject grammar to all language without having to enumerate all of them.

With this, we could use
```json
"grammars": [
     {
     "injectTo": ["source", "text"....]
// ....
}
     ]
```
instead of :
```json
"grammars": [
     {
     "injectTo": ["source.js", "source.ts", "source.jsx", "source.yaml", ....]
// ....
}
     ]
```

AdrieanKhisbe added a commit to AdrieanKhisbe/omni-tags.vscode that referenced this pull request May 29, 2018

@AdrieanKhisbe

This comment has been minimized.

Copy link
Contributor

AdrieanKhisbe commented Aug 27, 2018

Just a gentle reminder to get some input from you @alexandrudima :)
(as you were assigned by @weinand)

best regards :)

@alexandrudima

This comment has been minimized.

Copy link
Member

alexandrudima commented Nov 2, 2018

Thank you!

@alexandrudima alexandrudima merged commit dc1777c into Microsoft:master Nov 2, 2018

1 check passed

license/cla All CLA requirements met.

@alexandrudima alexandrudima added this to the November 2018 milestone Nov 2, 2018

@AdrieanKhisbe AdrieanKhisbe deleted the AdrieanKhisbe:grammar-injection-consider-general-types branch Nov 2, 2018

@AdrieanKhisbe

This comment has been minimized.

Copy link
Contributor

AdrieanKhisbe commented Nov 2, 2018

Awesome! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment