New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch name validation and whitespace config #50712

Merged
merged 2 commits into from Sep 13, 2018

Conversation

Projects
None yet
3 participants
@raix
Contributor

raix commented May 29, 2018

This pull request adds following options to the git extension.

  • Adds git.createBranchNameConvention.regexp
  • Adds git.createBranchWhitespaceChar

Preview:
vscode-create_branch_validation

This is an initial pr. with the implementation for further discussion, if this is something the vscode team would consider.

eg. if the change should enable extensions to lint/validate the branch name or be a configuration etc.

Fixes #50241

Preview of alternative: Adding an extension api, searching tickets not fixed - also write the branch name after whitespaces etc. have been replaced:
vscode-create_branch_validation_via_extension

Add branch name validation and whitespace config
* Adds `git.createBranchNameConvention.regexp`
* Adds `git.createBranchWhitespaceChar`

Fixes #50241
@raix

This comment has been minimized.

Show comment
Hide comment
@raix

raix Aug 27, 2018

Contributor

@joaomoreno is it possible to run this build again? I think to remember it failed installing npm modules.

Contributor

raix commented Aug 27, 2018

@joaomoreno is it possible to run this build again? I think to remember it failed installing npm modules.

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Aug 28, 2018

Member

@raix Let's merge master into it first, then a new build will be triggered.

Member

joaomoreno commented Aug 28, 2018

@raix Let's merge master into it first, then a new build will be triggered.

Merge remote-tracking branch 'Microsoft/master' into feature/50241-Ad…
…d_branch_name_validation

* Microsoft/master: (4802 commits)
  Fixes #57415: autoSurround - rename "always" to "languageDefined"
  debug: skip over %0
  explorer view: cut down delay time till progress from 3.2s to 1.2s
  file workspace suffix is empty string
  Revert "debug: do not send terminate to EH debugging"
  Fixes #57411: Rename `autoWrapping` to `autoSurround` to avoid confusions related to text wrapping
  Fixes #57453: Avoid thinking the user typed in the find input when setting the search string value
  Synchronisation notification: - Show extension being synchronised - Delete the downloaded extensions
  [html] fix tests
  debug: do not send terminate to EH debugging
  webpack - let build fail when webpack generates an error or a warning
  [html] update service. Fixes #57445
  node-debug@1.27.6
  more complete fix for #57483
  fix #57351
  fix #57483
  fixes #56015
  dispose of RunOnceScheduler properly
  Fixes Microsoft/monaco-editor#1021: Use ProviderResult in modes.ts
  fix #55607
  ...
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 13, 2018

Member

Thanks! 🍻

Did a few changes to the settings names.

Member

joaomoreno commented Sep 13, 2018

Thanks! 🍻

Did a few changes to the settings names.

@joaomoreno joaomoreno modified the milestones: Backlog, September 2018 Sep 13, 2018

@joaomoreno joaomoreno merged commit d6b82a5 into Microsoft:master Sep 13, 2018

2 checks passed

VS Code #20180829.68 succeeded
Details
license/cla All CLA requirements met.
Details
@raix

This comment has been minimized.

Show comment
Hide comment
@raix

raix Sep 21, 2018

Contributor

Thanks @joaomoreno sounds good 👍

Contributor

raix commented Sep 21, 2018

Thanks @joaomoreno sounds good 👍

@raix raix changed the title from Add branch name validation and whitespace config (WIP) to Add branch name validation and whitespace config Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment