New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitignore language #51026

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@Hirse
Contributor

Hirse commented Jun 3, 2018

See Microsoft/vscode-eslint#473
@aeschli, @dbaeumer
This only adds the Ignore-language and assigns it to .gitignore.
I would like to add a reference to it in extensions/npm for .npmignore. Is it possible to add that file association as contribution in the package.json or how would you propose to do it?

@octref octref requested a review from aeschli Jun 4, 2018

@aeschli

This comment has been minimized.

Contributor

aeschli commented Jun 4, 2018

That looks good. I'd suggest to give it id gitignore even if it is now used in many other contexts.
I'll make that change...
Thinking more about it, 'ignore' is fine as id.

@aeschli aeschli merged commit 439ac99 into Microsoft:master Jun 4, 2018

1 of 2 checks passed

VSTS: VS Code 20180603.1 failed
Details
license/cla All CLA requirements met.
Details

@aeschli aeschli added this to the June 2018 milestone Jun 4, 2018

@aeschli

This comment has been minimized.

Contributor

aeschli commented Jun 4, 2018

I added support for npmignore, see the change set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment