New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement smooth caret animation with toggleable setting #51197

Merged
merged 2 commits into from Nov 2, 2018

Conversation

Projects
None yet
4 participants
@JeffreyCA
Copy link
Contributor

JeffreyCA commented Jun 6, 2018

Addresses #20310

This Pull Request implements the option for having a smooth caret animation while typing, moving the cursor, and selecting text. It is very similar to the animation in Office 2013 and 2016 products.

This feature request was gaining some traction over the last couple of weeks, and today several people suggested how it could be implemented via a change in the CSS. This implementation is based on @IncognitoJam's suggestion here.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Jun 6, 2018

CLA assistant check
All CLA requirements met.

@JeffreyCA

This comment has been minimized.

Copy link
Contributor

JeffreyCA commented Jun 29, 2018

Any updates? @alexandrudima

@JeffreyCA

This comment has been minimized.

Copy link
Contributor

JeffreyCA commented Aug 6, 2018

@aeschli @alexandrudima any comments on this? It's been 2 months.

@JeffreyCA JeffreyCA force-pushed the JeffreyCA:smooth-caret-animation branch from 0fb92cb to 8d664e4 Aug 10, 2018

@alexandrudima

This comment has been minimized.

Copy link
Member

alexandrudima commented Nov 2, 2018

Works great! Thank you!

@alexandrudima alexandrudima added this to the November 2018 milestone Nov 2, 2018

@alexandrudima alexandrudima merged commit 1f9ec65 into Microsoft:master Nov 2, 2018

1 of 2 checks passed

VS Code in progress
Details
license/cla All CLA requirements met.
Details
@JeffreyCA

This comment has been minimized.

Copy link
Contributor

JeffreyCA commented Nov 2, 2018

Finally! Thanks for merging it in! 😃

@rainerklier

This comment has been minimized.

Copy link

rainerklier commented Nov 13, 2018

cool!

@JeffreyCA

This comment has been minimized.

Copy link
Contributor

JeffreyCA commented Nov 21, 2018

There's a small issue where after you toggle the setting, when you switch back to an editor tab the changes do not get applied immediately. I had to switch between two different tabs before the settings applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment