New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warning when tokenization is skipped #51265

Merged
merged 2 commits into from Jun 11, 2018

Conversation

Projects
None yet
3 participants
@wistcc
Contributor

wistcc commented Jun 6, 2018

This fixes #51127.

Here how it looks:
image

cc: @aeschli @alexandrudima

@aeschli

This comment has been minimized.

Contributor

aeschli commented Jun 7, 2018

Cool. You probably dont want to show a dialog per line, but once for the document. Also you don't want to show it every time again when the line is tokenized.

@wistcc

This comment has been minimized.

Contributor

wistcc commented Jun 7, 2018

@aeschli you are right. That's fixed now.

I wonder if we should also add a configuration property to not show this warning message. In case you think is a good idea, please let me know how it should be called so I can add it.

@alexandrudima

This comment has been minimized.

Member

alexandrudima commented Jun 11, 2018

👍

@alexandrudima alexandrudima merged commit b61725b into Microsoft:master Jun 11, 2018

1 of 2 checks passed

VSTS: VS Code 20180607.20 failed
Details
license/cla All CLA requirements met.

@alexandrudima alexandrudima added this to the June 2018 milestone Jun 11, 2018

@wistcc wistcc deleted the wistcc:WC/51127 branch Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment