New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add a missing return type for _hue2rgb #51285

merged 1 commit into from Jun 7, 2018


None yet
1 participant

ghost commented Jun 7, 2018

Change Logs:

  1. /vscode/src/vs/base/common/color.ts:
    _hue2rgb should have a return type in ts. The type shouldn't be missing.

@aeschli aeschli merged commit d5961f5 into Microsoft:master Jun 7, 2018

1 of 2 checks passed

VSTS: VS Code 20180607.3 failed
license/cla All CLA requirements met.

This comment has been minimized.


aeschli commented Jun 7, 2018

Thanks @Maledong !

@aeschli aeschli added this to the June 2018 milestone Jun 7, 2018

@aeschli aeschli self-assigned this Jun 7, 2018


This comment has been minimized.

ghost commented Jun 7, 2018

Nothing special :)
BTW:It seems that your build tool is wrong……? Publish part isn't working properly?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment