Remove VSash #51612
Merged
Remove VSash #51612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
added
debt
|
@joaomoreno @sandy081 pushed a fix (via 98d7de0) |
|
@joaomoreno In Settings editor, Right hand side editor is not taking the complete width
|
|
@sandy081 Please give it another go. |
|
@joaomoreno Only thing missing is reset on double click. Otherwise LGTM |
sandy081
approved these changes
Jun 12, 2018
joaomoreno
force-pushed
the
joao/remove-v-sash
branch
from
788ff56
to
050971d
Compare
|
@sandy081 Great catch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VSash's only purpose was to keep proportions on layout, which the Splitview does by default. This PR removesVSashand adopts the Splitview in the two places.@sandy081 Please review. The side-by-side comparison editor is currently broken in
master, @bpasero is fixing it. Once he does, we can merge master here and you can give it a try.