New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes stuck hover widget when triggered manually, with "editor.hover": false #52147

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
4 participants
@LeonardoBraga
Contributor

LeonardoBraga commented Jun 18, 2018

If the editor's preference editor.hover is set to false and the hover widget is triggered with CMD + K, CMD + I, it gets stuck in the page and does not go away with interactions such as mouse movement, mouse leave, editor scroll or editor model changes. This PR fixes this behaviour by hiding the tooltip when the above interactions happen.

Also, this PR adds support to react to changes on the preference editor.hover without having to reload the editor, effectively allowing the plugin suggested by @rebornix to work for the use case of #25715.

@msftclas

This comment has been minimized.

msftclas commented Jun 18, 2018

CLA assistant check
All CLA requirements met.

@LeonardoBraga LeonardoBraga changed the title from Fixes stuck hover widget when triggered manually, with `"editor.hover": false` to Fixes stuck hover widget when triggered manually, with "editor.hover": false Jun 18, 2018

@rebornix rebornix assigned alexandrudima and rebornix and unassigned rebornix Jun 18, 2018

Fixes stuck hover when manually triggered and "editor.hover" is false
- Adds support to toggle hover without reloading the editor
@LeonardoBraga

This comment has been minimized.

Contributor

LeonardoBraga commented Jun 23, 2018

This PR was in conflict after the commit from @alexandrudima on June 22nd, but I've addressed the conflicts and its merging cleanly again.

@alexandrudima / @rebornix could you please review and let me know if there's any value in merging or any other feedback? Thanks!

@alexandrudima

This comment has been minimized.

Member

alexandrudima commented Jun 25, 2018

👍 Thank you!

@alexandrudima alexandrudima merged commit aa8f371 into Microsoft:master Jun 25, 2018

2 checks passed

VSTS: VS Code 20180623.9 succeeded
Details
license/cla All CLA requirements met.
Details

@alexandrudima alexandrudima added this to the June 2018 milestone Jun 25, 2018

@LeonardoBraga LeonardoBraga deleted the LeonardoBraga:fixes-persistent-hover-manually-triggered branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment